Conversation
- updated tests for main - updated main.py to remove outdated api endpoints - deleted batch_job since no longer needed and breaking file - updated path_config for fallback in post_init
AwaisKamran
reviewed
May 16, 2025
AwaisKamran
reviewed
May 16, 2025
AwaisKamran
reviewed
May 16, 2025
AwaisKamran
reviewed
May 16, 2025
AwaisKamran
reviewed
May 16, 2025
AwaisKamran
reviewed
May 16, 2025
AwaisKamran
reviewed
May 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Coveralls for code coverage reporting into the Text2SQL repository, updates test configurations, and removes obsolete code.
- Added a .coveragerc file and GitHub Actions workflow for automated test coverage reporting.
- Removed the outdated batch_job.py file and unused masking endpoint, and updated tests for database change consistency.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/utilities/path_config.py | Changed post_init to return an empty string for consistency during tests |
| server/utilities/batch_job.py | Removed outdated batch job functionality |
| server/test/test_main.py | Updated tests to accommodate changes in masking and database change endpoints |
| server/requirements.txt | Added dependencies for pytest, pytest-cov, and coveralls |
| server/app/main.py | Removed obsolete endpoints for batch processing and file masking |
| .github/workflows/coverage.yaml | Added GitHub Actions workflow for test and coverage automation |
| .coveragerc | Added coverage configuration to include/exclude specific files |
AwaisKamran
approved these changes
May 20, 2025
Mehak-Conrad
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Integrate Coveralls with Text2SQL
This pull request implements Add Coveralls to Text2SQL Repo
Summary of Changes
Add
.coveragercconfigurationConfigures code coverage behavior. Key points:
server/constantsis excluded since those files default to 100% coverage.serverdirectory.Add GitHub Actions workflow
Introduces an Actions workflow to automate test coverage reporting via Coveralls.
Remove outdated
batch_job.pyThe
batch_job.pymodule and all related references have been deleted. This file was obsolete and caused compatibility breaking error during testing.Clean up unused references in
utility_functions.pyThe function
mask_question_and_answer_filesno longer exists, so related calls have been removed.Minor fixes in
test_main.pyUpdated test logic and imports to ensure all tests pass under the new configuration.
Update
path_config.pyfor test compatibilityModified
post_initto return an empty string instead ofNone, preventing runtime errors when running tests in environments without adata/directory.